Re: [PATCH 1/1] [Outreachy] merge-ours: include parse-options
From: George Espinoza <hidden>
Date: 2019-10-30 09:53:57
On Tue, Oct 29, 2019 at 7:05 PM Junio C Hamano [off-list ref] wrote:
"george espinoza via GitGitGadget" [off-list ref] writes:quoted
From: george espinoza <redacted> Teach this command which currently handles its own argv to use parse-options instead because parse-options helps make sure we handle user input like -h in a standardized way across the project.Sorry, but why do we even want to do this? merge-ours is an implementation detail of "git merge" and is never run directly by end-users.
Hello Junio, this is my mistake. I am a first time contributor. I'm currently working on Micro Project #3 as an Outreachy applicant that states, "Teach a command which currently handles its own argv how to use parse-options instead." I was under the impression that all commands with the NOPARSE_OPT flag in git.c needed parse-options added. I now see that I should take into account for commands that are only ran by end-users :)
I am not sure why it even needs "-h" in the first place, but that is already there, so letting sleeping dog lie would be what I would prefer. Is there a plan to add some -Xmerge-backend-option to this program, and would use of parse-options API make it easier? That would be a good reason to start using it in this program, but otherwise...
I will look into finding another command to contribute to instead after your feedback so I can fulfill Micro Project #3 since I had not thought of further plans past the parse-option replacement. Thank you for your input!