Thread (4 messages) 4 messages, 4 authors, 2019-10-31

Re: Re: [FR] Allow `git stash create` to include untracked changes

From: Kipras Melnikovas <hidden>
Date: 2019-10-28 16:30:02

Possibly related (same subject, not in this thread)

Hello,
thank you for the info.

It seems like neither worked:

export GIT_TEST_STASH_USE_BUILTIN=no
git config --global stash.usebuiltin no

The untracked files are still not stashed with `git stash create -u [some-argument]`, but are stashed successfully with `git stash push -u`,
so unless I'm doing something wrong, this also doesn't help, sadly.

Also, if there are no modified changes (only untracked ones), then `git stash create [-u [some-arg]]` (the non-builtin stash) will not even give you a commit object's name, thus it probably does not create the commit object at all.

Also, the manual page of git-stash(1) not mention the `--include-untracked` option - this is why I posted in the first place.

$ man git-stash
...
git stash create [<message>]
git stash store [-m|--message <message>] [-q|--quiet] <commit>
...

---

Is there any chance to

* get the builtin stash to support `--include-untracked` option?

* figure out if the legacy stash also works as intended with the `-u [some-arg]` option
	* when there aren't any changes, except untracked/ignored ones, the commit object doesn't seem to be created (printed) at all
	* why does it even require an argument?

* update the manual page for git-stash(1)

* check if everything's fine with `git stash store` too, just in case:D

Is there anything else I need to do to get this issue reported or are you guys taking care of it?

---

My stuff:

$ git --version
git version 2.23.0

$ uname -a
Linux arch-usb 5.3.7-arch1-1-ARCH #1 SMP PREEMPT Fri Oct 18 00:17:03 UTC 2019 x86_64 GNU/Linux

Thank you for your time and support:)
Kipras
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help