Thread (1 message) 1 message, 1 author, 2019-10-25

Re: [Outreachy][PATCH] abspath: reconcile `dir_exists()` and `is_directory()`

From: Junio C Hamano <hidden>
Date: 2019-10-25 02:41:01

Jeff King [off-list ref] writes:
Yeah, I think one path forward could be:

  - add path_exists(); this will work the same as file_exists(), but is
    a better name. Keep file_exists() for now, but put a comment that
    new calls should use path_exists().

  - use path_exists() in builtin/clone.c, ditching its custom
    dir_exists()
Both are of immediate value ;-)
  - (optional) start converting file_exists() calls to path_exists(),
    after confirming what each call wants (just files, or any path)
That is of lessor urgency but the result has a good documentation
value.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help