Re: [PATCH 4/6] index-pack: calculate {ref,ofs}_{first,last} early
From: Jeff King <hidden>
Date: 2019-10-17 06:31:49
From: Jeff King <hidden>
Date: 2019-10-17 06:31:49
On Wed, Oct 09, 2019 at 04:44:20PM -0700, Jonathan Tan wrote:
Whenever we make a struct base_data, immediately calculate its delta
children. This eliminates confusion as to when the
{ref,ofs}_{first,last} fields are initialized.That _seems_ like a good idea, but I'm a little worried just because I don't entirely understand why it was being done lazily before. If you've puzzled all that out, it would be nice to make the argument in the commit message. -Peff