Re: [PATCH v3 1/1] doc: Change zsh git completion file name
From: Junio C Hamano <hidden>
Date: 2019-10-16 02:06:16
"Maxim Belsky via GitGitGadget" [off-list ref] writes:
From: Maxim Belsky <redacted> Subject: Re: [PATCH v3 1/1] doc: Change zsh git completion file name
Lack of attention to the detail. This is not about changing the
filename anymore.
Subject: [PATCH v3] completion: clarify installation instruction for zsh
perhaps. I'll make the change locally, so unless there are other
changes you want to make, there is no need to resend.
Thanks.
quoted hunk
The original comment does not describe type of ~/.zsh/_git explicitly and zsh does not warn or fail if a user create it as a dictionary. So unexperienced users could be misled by the original comment. There is a small update to clarify it. Helped-by: Johannes Schindelin [off-list ref] Helped-by: Junio C Hamano [off-list ref] Helped-by: SZEDER Gábor [off-list ref] Signed-off-by: Maxim Belsky <redacted> --- contrib/completion/git-completion.zsh | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)diff --git a/contrib/completion/git-completion.zsh b/contrib/completion/git-completion.zsh index 886bf95d1f..b480e3f316 100644 --- a/contrib/completion/git-completion.zsh +++ b/contrib/completion/git-completion.zsh@@ -11,8 +11,9 @@ # # zstyle ':completion:*:*:git:*' script ~/.git-completion.zsh # -# The recommended way to install this script is to copy to '~/.zsh/_git', and -# then add the following to your ~/.zshrc file: +# The recommended way to install this script is to make a copy of it in +# '~/.zsh/' directory as '~/.zsh/_git' and then add the following to your +# ~/.zshrc file: # # fpath=(~/.zsh $fpath)