Re: [PATCH v2 1/1] doc: Change zsh git completion file name
From: Junio C Hamano <hidden>
Date: 2019-10-15 02:09:13
SZEDER Gábor [off-list ref] writes:
quoted
-# The recommended way to install this script is to copy to '~/.zsh/_git', and -# then add the following to your ~/.zshrc file: +# The recommended way to install this script is to make a copy of it in +# ~/.zsh/ directory as ~/.zsh/git-completion.zsh and then add the followingThese updated instructions don't work for me, following them gives me zsh's git completion instead of ours: ... Instructing users to copy our completion script to '~/.zsh/git-completion.zsh' goes against this convention. More importantly, it appears that this is more than a mere convention, maybe a requirement even; at least renaming our zsh completion script to follow the convention (IOW following the current install instructions) makes it work all of a sudden:
Thanks for a dose of sanity. My "Helped-by" was about phrasing and had nothing with the name of the file, so it should be fixable without invalidating it ;-)
-# The recommended way to install this script is to copy to '~/.zsh/_git', and -# then add the following to your ~/.zshrc file: +# The recommended way to install this script is to make a copy of it in +# ~/.zsh/ directory as ~/.zsh/git-completion.zsh and then add the following
# The recommended way to install this script is to make a copy of it in
# '~/.zsh/' directory as '~/.zsh/_git' and then add the following