Re: [PATCH 0/1] fsmonitor: don't fill bitmap with entries to be removed

Johannes Schindelin [off-list ref] writes:

Hi all,

On Thu, 3 Oct 2019, William Baker via GitGitGadget wrote:

quoted

This patch series fixes a segfault that I encountered while testing
fsmonitor. Under some circumstances, the fsmonitor extension was being
written with too many bits, and subsequent git commands would segfault when
trying to apply the bits to the index.

As part of these changes I've added some BUG checks that would have helped
catch this problem sooner. Special thanks to Dscho for pointing me in the
right direction and suggesting a test that can reproduce the issue.

Thanks, William

Please note that I was involved with the development of this patch,
reviewed a couple of iterations internally and am implictly okay with
this first public iteration.

IOW, "Reviewed-by: dscho".  That's good to hear.

THanks.