Thread (1 message) 1 message, 1 author, 2019-10-02

Re: [PATCH v2 1/6] midx: add MIDX_PROGRESS flag <snip>

From: Junio C Hamano <hidden>
Date: 2019-10-02 05:38:32

William Baker [off-list ref] writes:
I saw that the code base is currently a mix of #define and enums when it
comes to flags  (e.g. dir_struct.flags and rebase_options.flags are both
enums) and so using one here would not be something new stylistically.
Yes.  But it is a different matter to spread a bad practice to
parts of the code that haven't been contaminated by it.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help