Re: [PATCH v3] Documentation: fix build with Asciidoctor 2

On Sun, 15 Sep 2019 at 23:26, brian m. carlson
[off-list ref] wrote:

On 2019-09-15 at 09:59:52, SZEDER Gábor wrote:

quoted

On Sat, Sep 14, 2019 at 07:49:19PM +0000, brian m. carlson wrote:

quoted

    test -n "$ALREADY_HAVE_ASCIIDOCTOR" ||
    gem install --version 1.5.8 asciidoctor

So, since the documentation can now be built with Asciidoctor v2, is
it already time to remove this '--version 1.5.8'?

I think Martin was going to send in some more patches before we did
that.

I've got two series floating around [1] [2]. I'll be rerolling [2]
hopefully tonight and then I feel pretty good about the manpages. I've
got a third series that I'll get to then, which fixes up the rendering
of user-manual.pdf/html with Asciidoctor. Assuming those three series
graduate, I'm not aware of any reason to hold off on the switch to
"Asciidoctor by default".

As for "v2.x vs 1.5.8", that seems like a separate issue to me, though
-- and one that your patch does a very good job at! My series [2] will
make the rendering with v2.x /prettier/, but since your series makes the
docs build /at all/, maybe it's worth switching the CI-job sooner rather
than later to make sure we keep it so.

[1] https://public-inbox.org/git/cover.1567707999.git.martin.agren@gmail.com/

[2] https://public-inbox.org/git/cover.1567534373.git.martin.agren@gmail.com/

Martin