Thread (1 message) 1 message, 1 author, 2019-09-13

Re: [PATCH] list-objects: don't queue root trees unless revs->tree_objects is set

From: Junio C Hamano <hidden>
Date: 2019-09-13 18:05:23

Jeff King [off-list ref] writes:
quoted
Thanks for spotting it.  I wonder if it was broken like this forever
since the beginning X-<.
Not quite since the beginning; it comes from 8d2dfc49b1
(process_{tree,blob}: show objects without buffering, 2009-04-10). I
suspect nobody noticed because the cost for the normal case is really
just shuffling some pointers around. It's only because it actively works
against the commit-graph optimizations that it's so expensive there.
Yeah, that is what I meant by "since the beginning" (of
commit-graph, that is).
I was surprised (and pleased) by how much such a simple thing helped.
Yes, it is very pleasing.  Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help