Re: [PATCH 2/2] ci: restore running httpd tests
From: Junio C Hamano <hidden>
Date: 2019-09-06 17:03:11
SZEDER Gábor [off-list ref] writes:
Once upon a time GIT_TEST_HTTPD was a tristate variable and we exported 'GIT_TEST_HTTPD=YesPlease' in our CI scripts to make sure that we run the httpd tests in the Linux Clang and GCC build jobs, or error out if they can't be run for any reason [1].
Wow. I vaguely recall having mumbled about keeping YesPlease as an extra synomym for 'yes' for safety against misconversions, as its use in the build/test infrastructure is so ingrained, but at the end went with the standard set of boolean without doing such extending, with the hope that soon any misconversion would be found out. This discovery of a misconversion took 3 months, which may or may not match the definition of "soon" X-<. The fix is obviously correct. Thanks.
quoted hunk
Then 3b072c577b (tests: replace test_tristate with "git env--helper", 2019-06-21) came along, turned GIT_TEST_HTTPD into a bool, but forgot to update our CI scripts accordingly. So, since GIT_TEST_HTTPD is set explicitly, but its value is not one of the standardized true values, our CI jobs have been simply skipping the httpd tests in the last couple of weeks. Set 'GIT_TEST_HTTPD=true' to restore running httpd tests in our CI jobs. [1] a1157b76eb (travis-ci: set GIT_TEST_HTTPD in 'ci/lib-travisci.sh', 2017-12-12) Signed-off-by: SZEDER Gábor <redacted> --- ci/lib.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/ci/lib.sh b/ci/lib.sh index 44db2d5cbb..29dc740d40 100755 --- a/ci/lib.sh +++ b/ci/lib.sh@@ -160,7 +160,7 @@ linux-clang|linux-gcc) export CC=gcc-8 fi - export GIT_TEST_HTTPD=YesPlease + export GIT_TEST_HTTPD=true # The Linux build installs the defined dependency versions below. # The OS X build installs much more recent versions, whichever