Re: [PATCH bc/hash-independent-tests-part-4] t: decrease nesting in test_oid_to_path
From: brian m. carlson <hidden>
Date: 2019-08-08 11:35:49
Attachments
- signature.asc [application/pgp-signature] 868 bytes
From: brian m. carlson <hidden>
Date: 2019-08-08 11:35:49
On 2019-08-08 at 09:37:33, Jeff King wrote:
On Wed, Aug 07, 2019 at 11:56:14PM -0700, Jonathan Nieder wrote: -- >8 -- Subject: [PATCH] t0000: reword comments for "local" test Commit 01d3a526ad (t0000: check whether the shell supports the "local" keyword, 2017-10-26) added a test to gather data on whether people run the test suite with shells that don't support "local". After almost two years, nobody has complained, and several other uses have cropped up in test-lib-functions.sh. Let's declare it acceptable to use.
I'm also in favor of this patch. To my knowledge, the only FLOSS POSIX-compliant shell that doesn't support "local" is AT&T ksh, so there are a lot of alternatives that folks have (bash, dash, posh, zsh, mksh, pdksh, busybox sh, etc.) in case they have a less capable shell. -- brian m. carlson: Houston, Texas, US OpenPGP: https://keybase.io/bk2204