Re: Weird behavior with git grep --recurse-submodules

On Mon, Jul 29, 2019 at 1:27 PM Matheus Tavares Bernardino
[off-list ref] wrote:

On Tue, Jul 16, 2019 at 3:09 PM Daniel Zaoui [off-list ref] wrote:

quoted

Hi Matheus,

Hi, Daniel

I'm sorry, your last message went to my spam folder for some reason :(

quoted

Thank you for your response.

I really hope the change Brandon made is not a project decision. At least, it does seem to me like a bug.

Since I'm the one who originally implemented the --recurse-submodules
feature to git grep back in
0281e487f (grep: optionally recurse into submodules, 2016-12-16) and
then subsequently changed
the implementation to do the recursion in process in  f9ee2fc ("grep:
recurse in-process using
'struct repository'", 02-08-2017) I can say it was definitely a bug I
introduced during the conversion
as I don't believe I would have intended to introduce that change of
behavior (especially without
documenting it).

quoted

How do you recommend me to solve this issue? Is there some place where I can check if some bug ticket has been created on this matter? I didn't find anything in the mailing list archives about this.

I think I manage to solve the bug with this[1] patch. I'm going to ask
my GSoC mentors to take a look and then I'll send it to the mailing
list :) Thanks for reporting it.

Best,
Matheus

[1]: https://github.com/matheustavares/git/commit/37aeeb3ab86b5dfebfaafeb98d34e379341a529d