Thread (2 messages) 2 messages, 2 authors, 2019-07-30

Re: [PATCHv2] send-email: Ask if a patch should be sent twice

From: Dmitry Safonov <hidden>
Date: 2019-07-30 20:26:51

On 7/30/19 8:35 PM, Junio C Hamano wrote:
SZEDER Gábor [off-list ref] writes:
quoted
On Tue, Jul 30, 2019 at 05:26:24PM +0100, Dmitry Safonov wrote:
quoted
+	if (@dupes) {
+		printf(__("Patches specified several times: \n"));
Is this message translated?  (I don't know what __("<str>") does in
Perl.)  If it is, then ...
That's not "in Perl" per-se, but what our own Git::I18N gives us.
quoted
quoted
+test_expect_success $PREREQ 'ask confirmation for double-send' '
+	clean_fake_sendmail &&
+	echo y | \
+		GIT_SEND_EMAIL_NOTTY=1 \
+		git send-email --from=author@example.com \
+			--to=nobody@example.com \
+			--smtp-server="$(pwd)/fake.sendmail" \
+			--validate \
+			$patches $patches $patches \
+			>stdout &&
+	! grep "Patches specified several times: " stdout
... this here should be 'test_i18ngrep' instead of plain old 'grep'.
Yup.  Thanks for carefully reading the patch(es), as always.
Thanks for spotting, will fix in v3.

-- 
          Dmitry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help