Re: [PATCHv2] send-email: Ask if a patch should be sent twice
From: SZEDER Gábor <hidden>
Date: 2019-07-30 19:19:14
On Tue, Jul 30, 2019 at 05:26:24PM +0100, Dmitry Safonov wrote:
+ if (@dupes) {
+ printf(__("Patches specified several times: \n"));
Is this message translated? (I don't know what __("<str>") does in
Perl.) If it is, then ...
quoted hunk ↗ jump to hunk
@@ -589,6 +591,19 @@ test_expect_success $PREREQ 'In-Reply-To with --chain-reply-to' ' test_cmp expect actual ' +test_expect_success $PREREQ 'ask confirmation for double-send' ' + clean_fake_sendmail && + echo y | \ + GIT_SEND_EMAIL_NOTTY=1 \ + git send-email --from=author@example.com \ + --to=nobody@example.com \ + --smtp-server="$(pwd)/fake.sendmail" \ + --validate \ + $patches $patches $patches \ + >stdout && + ! grep "Patches specified several times: " stdout
... this here should be 'test_i18ngrep' instead of plain old 'grep'.