Thread (1 message) 1 message, 1 author, 2019-07-23

Re: [GSoC][PATCH v2 1/1] rebase -i: add --ignore-whitespace flag

From: Junio C Hamano <hidden>
Date: 2019-07-23 20:57:13

Rohit Ashiwal [off-list ref] writes:
Hi Junio

On Fri, 19 Jul 2019 14:33:49 -0700 Junio C Hamano [off-list ref] wrote:
quoted
quoted
 t/t3431-rebase-options-compatibility.sh | 66 +++++++++++++++++++++++++
Isn't 3431 already taken?
It is not in git/git[1].
That's a very selfish attitude ;-)  Pay attention to what others are
doing while you are working on this topic (hint: do not limit your
check to 'master', but make sure your changes also work well when
merged to 'next' and 'pu'---make a trial merge or two and run test
suite, for example).
quoted
quoted
+	git checkout --orphan master &&
+	q_to_tab >file <<-EOF &&
+	line 1
+	        line 2
+	line 3
+	EOF
This will trigger "indent-with-space".  Instead of using q-to-tab,
perhaps something like this would be more appropriate (not limited
to this piece, but also other ones in this script that actually do
use Q to visualize a tab)?

	sed -e "s/^|//" >file <<-EOF &&
	|line 1
	|        line 2
	|line 3
	EOF
Oh! My mistake, I should have used cat instead.
I am not sure how you would avoid indent-with-space with "cat".
With the use of "sed" like I showed above to spell the left margin
explicitly out, we can---I am not saying it's the only way, but I do
not think of a clean way to do the same with "cat".
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help