Thread (5 messages) 5 messages, 4 authors, 2019-07-01

Re: [PATCH 1/1] Let rebase.reschedulefailedexec only affect interactive rebases

From: Johannes Schindelin <hidden>
Date: 2019-07-01 11:52:33

Hi,

On Sun, 30 Jun 2019, Phillip Wood wrote:
On 28/06/2019 23:08, Junio C Hamano wrote:
quoted
Phillip Wood [off-list ref] writes:
quoted
One potential problem is if someone has an alias that always sets
--reschedule-failed-exec but does not always add --exec to the
command line.
Such a use case would be hitting this die() already without this
topic, wouldn't it?  In which case we can say there is no "someone"
with such an alias.
It depends what else the alias includes, if it also includes
-i/-k/-r/--signoff then it wont have been dying but will if we start
requiring --exec and they don't set that.
The entire reasoning behind the config variable was that it would allow
changing the behavior just in case that the interactive rebase backend was
in use.

In other words: I tried to introduce that config variable to prevent
people from having afore-mentioned problems with the command-line option.

Therefore, from my perspective, it makes more sense to define such an
alias using `-c ...` than using `--reschedule-failed-exec`, unless the
alias is definitely only intended to launch interactive rebases.

Ciao,
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help