Thread (1 message) 1 message, 1 author, 2019-06-13

Re: [PATCH v8 7/9] blame: add a fingerprint heuristic to match ignored lines

From: Junio C Hamano <hidden>
Date: 2019-06-13 16:38:41

SZEDER Gábor [off-list ref] writes:
quoted
+	git blame --ignore-rev $REV_2 --ignore-rev $REV_3 file | sed -e "$pick_author" >actual &&
Please use an intermediate file between 'git blame' and the downstream
'sed' command, here and in other tests as well.

This test script focuses specifically on 'git blame', but that pipe
hides its exit code.
Good point on "this matters even more for 'blame' as the whole point
of t8014 _is_ about 'blame' running corretly".

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help