Re: [PATCH 03/10] t1450: make hash size independent
From: Jonathan Tan <hidden>
Date: 2019-06-11 23:03:03
quoted hunk ↗ jump to hunk
@@ -84,7 +86,7 @@ test_expect_success 'branch pointing to non-commit' ' test_expect_success 'HEAD link pointing at a funny object' ' test_when_finished "mv .git/SAVED_HEAD .git/HEAD" && mv .git/HEAD .git/SAVED_HEAD && - echo 0000000000000000000000000000000000000000 >.git/HEAD && + echo $ZERO_OID >.git/HEAD && # avoid corrupt/broken HEAD from interfering with repo discovery test_must_fail env GIT_DIR=.git git fsck 2>out && cat out &&
ZERO_OID doesn't seem redefined to the SHA256 variant when being tested under SHA256. Maybe you need a test_oid invocation here. I couldn't verify this, though - do you know if there is a way for me to run the tests with SHA256 instead of SHA1?
quoted hunk ↗ jump to hunk
@@ -417,13 +426,12 @@ test_expect_success 'force fsck to ignore double author' ' ' _bz='\0' -_bz5="$_bz$_bz$_bz$_bz$_bz" -_bz20="$_bz5$_bz5$_bz5$_bz5" +_bzoid=$(printf $ZERO_OID | sed -e 's/00/\\0/g')
Same comment here.
quoted hunk ↗ jump to hunk
@@ -631,10 +639,12 @@ test_expect_success 'fsck --name-objects' ' test_expect_success 'alternate objects are correctly blamed' ' test_when_finished "rm -rf alt.git .git/objects/info/alternates" && + path=$(test_oid numeric) && + path=$(test_oid_to_path "$path") &&
Double assignment to path?