Thread (4 messages) 4 messages, 4 authors, 2019-05-30

Re: What's cooking in git.git (May 2019, #04; Tue, 28)

From: Jeff King <hidden>
Date: 2019-05-30 11:51:31

On Wed, May 29, 2019 at 09:53:44AM -0700, Junio C Hamano wrote:
quoted
quoted
* ds/object-info-for-prefetch-fix (2019-05-28) 1 commit
 - sha1-file: split OBJECT_INFO_FOR_PREFETCH

 Code cleanup.

 Will merge to 'next'.
I think this one is actually a bug-fix (we are refusing to prefetch for
"QUICK" calls even though was not the intent), and it is new in this
release.

I'm not sure of the user-visible impacts, though. There are a lot of
QUICK calls, and I'm not sure for which ones it is important to fetch.
Hmph.  I took it as primarily futureproofing, as I didn't find a way
to trigger bad behaviour from within the current codebase.
Hmm. Looking over the uses of OBJECT_INFO_QUICK, they all seem to be in
either index-pack or as part of a fetch operation. And in both of those
cases, we'd disable the whole feature anyway with fetch_if_missing.

So I _think_ you are right, and there isn't a way to trigger it.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help