Thread (1 message) 1 message, 1 author, 2019-05-13

Re: [PATCH 01/14] cmd_{read,write}_tree: rename "unused" variable that is used

From: Junio C Hamano <hidden>
Date: 2019-05-13 05:14:19

Jeff King [off-list ref] writes:
I kind of hate "cmd_prefix"; I was tempted to just call it "prefix" so
that all of the cmd_* functions were consistent, but I worried that it
really would get confused with the local variables (even if those
variables are renamed, as I do here).
I tend to agree with your temptation to make things consisten,
especially because you already do the renaming of existing "prefix"
to "tree_prefix".

Perhaps in a few release cycles, these can be renamed again to be
consistent with everybody else, and I won't die if this were called
cmd_prefix until then ;-)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help