Re: [GSoC] microporject test_path_is_*
From: Elijah Newren <hidden>
Date: 2019-03-26 22:06:50
Hi, On Tue, Mar 26, 2019 at 2:10 PM Mooga [off-list ref] wrote:
Hi, I am still a bit confused about the task itself it’s just text replacing for example: t1400-update-ref.sh , line 194 -> `test_path_is_missing` has to be ‘test_path_is_file’ Thanks
There are several places in the code that use test with -e or -f or -d (or -h or...) in order to check for the presence of a file/directory/symlink/etc. For example, test -f path1/file1 This could be made more clear and produce nicer error messages if it were instead test_path_is_file path1/file1 There are likewise several that use one of ! test -e path/to/filename or ! test -f path/to/filename or test ! -f path/to/filename which could be replaced by test_path_is_missing path/to/filename This GSoC microproject is just about picking one testfile that has some of these constructs, and fixing the cases found within that testfile.