Re: [RFC/PATCH] point pull requesters to Git Git Gadget
From: Junio C Hamano <hidden>
Date: 2019-03-19 00:30:45
Jeff King [off-list ref] writes:
On Mon, Mar 18, 2019 at 09:48:42PM +0000, Thomas Gummerer wrote:quoted
quoted
It looks like GitGitGadget just uses normal SMTP to submit the messages. I wonder if normal people using gmail as their SMTP server for send-email also suffer from this. I've not ever noticed it, but I don't know how common that setup is.I am using gmail as my SMTP server with 'git send-email', and it doesn't look like gmail is rewriting anything there, see [*1*] for example. The date header looks like this: Date: Mon, 25 Feb 2019 23:16:04 +0000 Note the +0000 there, compared to the GMT that GitGitGadget uses. Looking at RFC2822, that's the new version of specifying the timezone, while GMT is only defined in the obsolete time and date section. I guess gmail might just not like that anymore and rewrite it. So fixing this might not be that hard, and might not involve sleeping while sending the patch series at all. Changing how the date is calculated in [*2*] might be all that's needed.Yes, if it really is as simple as just "gmail doesn't like our date format, so it rewrites the header", that would be wonderful. Thanks for an extra data point.
I use send-email through SMTP MSA at either gmail or pobox depending on the phase of the moon, and never noticed an issue with the timestamp we generate. But I noticed the "GMT" string in the "original-date" trail in the problem message, which I didn't think was an timestamp we would generate but somebody else might, and that was why I quoted it in my message. It is good that Thomas noticed it, came up with a conjecture and a pointer to a possible fix ;-) Thanks, all.