Thread (1 message) 1 message, 1 author, 2019-03-18

Re: [WIP PATCH/RFC] Use a higher range-diff --creation-factor for format-patch

From: Junio C Hamano <hidden>
Date: 2019-03-18 05:23:14

Eric Sunshine [off-list ref] writes:
So, I'm fairly negative on this change. However, that doesn't mean I
would oppose tweaking the value shared between the two programs (and
also the default used by GitGitGadget, if it specifies it manually),
though I defer to Dscho in that regard.
I do not think of a good reason why the command should behave
differently only when run from inside format-patch, and if we were
changing anything, perhaps raising it a bit for all may make sense.
I have yet to see range-diff getting confused and matching wrong
patches but often seee it being too conservative to match two
iterations of the same patch after a moderate amount of update.

I find myself passing "--creation-factor 99" or some absurdly
looking value when accepting a rerolled series.  The most recent was
the updated 'clean-up merge message with scissors' from Denton
[*1*].


[Footnote]

*1* [ref]
and [ref]
do not line up without a high creation factor.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help