Thread (1 message) 1 message, 1 author, 2019-03-13

Re: [PATCH v1 06/11] restore: add --worktree and --index

From: Junio C Hamano <hidden>
Date: 2019-03-13 22:43:03

Elijah Newren [off-list ref] writes:
quoted
+               /*
+                * NEEDSWORK: if --worktree is not specified, we
+                * should save stat info of checked out files in the
+                * index to avoid the next (potentially costly)
+                * refresh. But it's a bit tricker to do...
+                */
+               rollback_lock_file(&lock_file);
A total tangent: I see both FIXME and NEEDSWORK in the codebase.
Are there other 'keywords' of this type that we use?  Is there a
preference for how they are used?
If it makes it simpler, I can easily declare that NEEDSWORK is the
preferred one (I do not think I ever wrote anything else) to avoid
wasting list bandwidth ;-)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help