Thread (26 messages) 26 messages, 4 authors, 2019-03-08

Re: [PATCH 2/2] setup: don't fail if commondir reference is deleted.

From: Eric Sunshine <hidden>
Date: 2019-02-18 21:00:41

On Mon, Feb 18, 2019 at 12:05 PM Michal Suchanek [off-list ref] wrote:
When adding wotktrees git can die in get_common_dir_noenv while
examining existing worktrees because the commondir file does not exist.
Rather than testing if the file exists before reading it handle ENOENT.
This commit message leaves the reader wondering under what conditions
"commondir file" might not exist. For instance, the reader might
wonder "iIs it simply a condition of normal operation or does it arise
under odd circumstances?". Without this information, it is difficult
for someone reading the explanation to understand if or how this code
might validly be changed in the future. Your cover letter contained
explanation which likely ought to be duplicated here as an aid to
future readers.
Signed-off-by: Michal Suchanek <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help