Thread (2 messages) flat view 2 messages, 2 authors, 2019-02-18

Re: [PATCH v7 1/3] ref-filter: add worktreepath atom

From: Nickolai Belakovski <hidden>
Date: 2019-02-18 10:10:16

Well, it sounded like we didn't like the ":" extender from another
conversation on this thread. Do you think this patch should move back
in that direction?

On Tue, Feb 5, 2019 at 3:14 AM Junio C Hamano [off-list ref] wrote:
Nickolai Belakovski [off-list ref] writes:
quoted
There's been a little back and forth on it, but my understanding is
that using the colon separator bypasses the caching mechanism in the
atoms, so every instance of "worktree:path" in a format string would
require a lookup.
Would that be a problem, though?  You now have a singleton hashmap
that is a file-scope global not tied to any particular atom, so...?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help