Re: [PATCH v2] tests: avoid syntax triggering old dash bug
From: Junio C Hamano <hidden>
Date: 2019-02-13 21:43:33
Ævar Arnfjörð Bjarmason [off-list ref] writes:
Avoid a bug in dash that's been fixed ever since its
ec2c84d ("[PARSER] Fix clobbering of checkkwd", 2011-03-15)[1] first
released with dash v0.5.7 in July 2011. This failing test was
introduced in 5f9674243d ("config: add --expiry-date", 2017-11-18).Thanks for not forgetting an year-old topic. The offending commit predates 2.16.0 that is a while ago ;-)
quoted hunk
This isn't a 2.21 regression, but sending it in the rc window anyway in case you'd like to queue an obviously working minor portability fix. t/t1300-config.sh | 1 + 1 file changed, 1 insertion(+)diff --git a/t/t1300-config.sh b/t/t1300-config.sh index 9652b241c7..428177c390 100755 --- a/t/t1300-config.sh +++ b/t/t1300-config.sh@@ -892,6 +892,7 @@ test_expect_success 'get --expiry-date' ' 1510348087 0 EOF + : "work around heredoc parsing bug fixed in dash 0.5.7 (in ec2c84d)" && { echo "$rel_out $(git config --expiry-date date.valid1)" git config --expiry-date date.valid2 &&