Re: [PATCH 1/2] t/lib-gpg: quote path to ${GNUPGHOME}/trustlist.txt
From: Todd Zullinger <hidden>
Date: 2019-02-08 20:31:52
SZEDER Gábor wrote:
On Thu, Feb 07, 2019 at 10:17:45PM -0500, Todd Zullinger wrote:quoted
When gpgsm is installed, lib-gpg.sh attempts to update trustlist.txt to relax the checking of some root certificate requirements. The path to "${GNUPGHOME}" contains spaces which cause an "ambiguous redirect" warning when bash is used to run the tests:s/error/warning/
Did you mean s/warning/error/ so the sentence reads:
The path to "${GNUPGHOME}" contains spaces which cause
an "ambiguous redirect" error when bash is used to run
the tests
?
Is it worth a resend before Junio queues it?
quoted
$ bash t7030-verify-tag.sh /git/t/lib-gpg.sh: line 66: ${GNUPGHOME}/trustlist.txt: ambiguous redirect ok 1 - create signed tags ok 2 # skip create signed tags x509 (missing GPGSM) ... No warning is issued when using bash called as /bin/sh, dash, or mksh.Likewise. POSIX says that no field splitting should be performed on the result of a parameter expansion that is used as the target of a redirection, but Bash doesn't conform in this respect (unless in POSIX mode).
I wish I'd remembered reading your detailed explanation of this¹ when I was testing and writing the commit message. :) ¹ https://public-inbox.org/git/20180926121107.GH27036@localhost/ -- Todd