Thread (16 messages) 16 messages, 4 authors, 2019-01-22

Re: [PATCH v2 1/3] Move init_skiplist() outside of fsck

From: Ævar Arnfjörð Bjarmason <hidden>
Date: 2019-01-18 09:45:48

On Thu, Jan 17 2019, Barret Rhoden wrote:
-		die("Could not open skip list: %s", path);
[...]
+		die("Could not open skip list: %s", path);
You're just moving this around, but now that this has two uses let's say
"Could not open SHA-1 list; %s" or something like that.
+			die("Invalid SHA-1: %s", sb.buf);
Unlike Johannes I think it's fine to leave this. This file-format is
SHA-1 only now. We can cross the bridge of making it (and others)
SHA-256 somehow when we come to that, whether that'll be allowing
variable width or a different file.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help