Re: [PATCH v2 0/4] Sideband the whole fetch v2 response
From: Junio C Hamano <hidden>
Date: 2019-01-15 19:50:22
Jonathan Tan [off-list ref] writes:
quoted hunk
@@ -474,6 +474,7 @@ void packet_reader_init(struct packet_reader *reader, int fd, reader->buffer = packet_buffer; reader->buffer_size = sizeof(packet_buffer); reader->options = options; + reader->me = "git"; }
This was somewhat unexpected. I would have thought that an
interdiff would be more like
+ reader.me = "fetch-pack";
if (using sideband-all) {
reader.use_sideband = 1;
- reader.me = "fetch-pack";
}
+ case SIDEBAND_PRIMARY: + if (reader->pktlen != 1) + goto nonprogress_received; + /* + * Since the packet contains nothing but the sideband + * designator, this is a keepalive packet. Wait for the + * next one. + */ + break; + default: /* SIDEBAND_PROGRESS */ + ;
OK. Will replace. Thanks.