Thread (40 messages) 40 messages, 3 authors, 2019-03-06
STALE2679d
Revisions (2)
  1. v1 [diff vs current]
  2. v2 current

[PATCH v2 1/3] setup: free old value before setting `work_tree`

From: Martin Ågren <hidden>
Date: 2019-01-14 18:35:10
Subsystem: the rest · Maintainer: Linus Torvalds

Before assigning to `data->work_tree` in `read_worktree_config()`, free
any value we might already have picked up, so that we do not leak it.

Signed-off-by: Martin Ågren <redacted>
---
 setup.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/setup.c b/setup.c
index 1be5037f12..bb633942bb 100644
--- a/setup.c
+++ b/setup.c
@@ -411,6 +411,7 @@ static int read_worktree_config(const char *var, const char *value, void *vdata)
 	} else if (strcmp(var, "core.worktree") == 0) {
 		if (!value)
 			return config_error_nonbool(var);
+		free(data->work_tree);
 		data->work_tree = xstrdup(value);
 	}
 	return 0;
-- 
2.20.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help