Re: [PATCH] remote: check config validity before creating rewrite struct
From: Junio C Hamano <hidden>
Date: 2019-01-12 02:36:50
Jeff King [off-list ref] writes:
This was a minor cleanup I mentioned in: https://public-inbox.org/git/20181122173109.GI28192@sigill.intra.peff.net/ but didn't get picked up.
Yeah, that does sound vaguely familiar ;-) Thanks, will queue.
quoted hunk
remote.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/remote.c b/remote.c index 670dd44813..9cc3b07d21 100644 --- a/remote.c +++ b/remote.c@@ -337,14 +337,14 @@ static int handle_config(const char *key, const char *value, void *cb) if (!name) return 0; if (!strcmp(subkey, "insteadof")) { - rewrite = make_rewrite(&rewrites, name, namelen); if (!value) return config_error_nonbool(key); + rewrite = make_rewrite(&rewrites, name, namelen); add_instead_of(rewrite, xstrdup(value)); } else if (!strcmp(subkey, "pushinsteadof")) { - rewrite = make_rewrite(&rewrites_push, name, namelen); if (!value) return config_error_nonbool(key); + rewrite = make_rewrite(&rewrites_push, name, namelen); add_instead_of(rewrite, xstrdup(value)); } }