Re: [Patch v5 3/4] git-compat-util.h: add FLOSS headers for HPE NonStop

"Randall S. Becker" [off-list ref] writes:

On January 3, 2019 16:41, Eric Sunshine wrote:

quoted

On Thu, Jan 3, 2019 at 4:04 PM [off-list ref] wrote:

quoted

The HPE NonStop (a.k.a. __TANDEM) platform cannot build git without
using the FLOSS package supplied by HPE. The convenient location for
including the relevant headers is in this file.

The NSIG define is also not defined on __TANDEM, so we define it here
as 100 if it is not defined only for __TANDEM builds.

Signed-off-by: Randall S. Becker <redacted>
---

diff --git a/git-compat-util.h b/git-compat-util.h @@ -397,6 +397,17

@@ static inline char *git_find_last_dir_sep(const char *path)
+#ifdef __TANDEM
+#include <floss.h(floss_execl,floss_execlp,floss_execv,floss_execvp)>
+#include <floss.h(floss_getpwuid)>
+#ifndef NSIG
+/* NonStop NSE and NSX do not provide NSIG. SIGGUARDIAN(99) is the

highest

quoted

+   known, by detective work using kill -l as a list is all signals
+   instead of signal.h where it should be. */

Style nit: With two minor exceptions, all other multi-line comments in this file
are formatted as:

/*
 * Multi-line
 * comment.
 */

Doh! I just missed that one. I'll fix this on the next round, if that's ok.

Again, I've queued with a tweak already, i.e. no need to reroll only
to fix this one.

Thanks, both.