Re: [Patch v5 2/4] config.mak.uname: support for modern HPE NonStop config.
From: Junio C Hamano <hidden>
Date: 2019-01-03 22:09:16
"Randall S. Becker" [off-list ref] writes:
On January 3, 2019 16:38, Eric Sunshine wrote:quoted
On Thu, Jan 3, 2019 at 4:04 PM [off-list ref] wrote:quoted
A number of configuration options are not automatically detected by configure mechanisms, including the location of Perl and Python. There was a problem at a specific set of operating system versions that caused getopt to have compile errors. Account for this by providing emulation defines for those versions. Signed-off-by: Randall S. Becker <redacted> ---diff --git a/config.mak.uname b/config.mak.uname @@ -470,7 +487,7@@quoted
ifeq ($(uname_S),NONSTOP_KERNEL) NO_MKDTEMP = YesPlease OLD_ICONV = UnfortunatelyYes - NO_REGEX = YesPlease + NO_REGEX=NeedsStartEnd NO_PTHREADS = UnfortunatelyYesStyle nit (probably not worth a re-roll): you lost the whitespace surrounding '='I can fix this one in the next round of changes, or after this gets in, if that works, or signoff on this being fixed in place.
I've already tweaked this while queuing. i.e. no need to resend only to fix this one. Thanks, both.