Re: [PATCH v2] doc: remove unneeded TODO for release_commit_memory
From: Junio C Hamano <hidden>
Date: 2019-01-03 07:22:01
Duy Nguyen [off-list ref] writes:
On Wed, Jan 2, 2019 at 3:09 AM Albert Burt [off-list ref] wrote:quoted
Remove TODO that was left in from: commit 110240588d (Merge branch 'sb/object-store-alloc' - 2018-06-25) Todo can be removed as: 9d2c97016f (commit.h: delete 'util' field in struct commit - 2018-05-19) deletes commit->util. Signed-off-by: Albert Burt <redacted> --- Thanks for looking at this for me Duy. I updated some of the changes you suggested. Let me know if there's anything else that I would need to clean up, or do better. :)Nope. The patch looks good to me.
Yes, but we'll fix this with 6a7895fd ("commit: prepare
free_commit_buffer and release_commit_memory for any repo",
2018-12-14) anyway, so I am not sure if this is worth pursuing
separately.
quoted
commit.c | 2 -- 1 file changed, 2 deletions(-)diff --git a/commit.c b/commit.c index 2d94e0b199..2ff6dca0bc 100644 --- a/commit.c +++ b/commit.c@@ -357,8 +357,6 @@ void release_commit_memory(struct commit *c) c->index = 0; free_commit_buffer(c); free_commit_list(c->parents); - /* TODO: what about commit->util? */ - c->object.parsed = 0; } --2.17.2 (Apple Git-113)