Thread (1 message) 1 message, 1 author, 2018-12-14

Re: [PATCH v2 1/2] .gitattributes: ensure t/oid-info/* has eol=lf

From: Junio C Hamano <hidden>
Date: 2018-12-14 02:23:50

Derrick Stolee [off-list ref] writes:
quoted
FWIW, I personally do not think "is sensitive to CRLF" is too bad,
as my attempt to clarify it does not make it much better, e.g.

	The logic to read from these files in shell uses built-in
	"read" command, which leaves CR at the end of these text
	files when they are checked out with CRLF line endings, at
	least when run with bash shipped with Git for Windows.  This
	results in an unexpected value in the variable these lines
	are read into, leading the tests to fail.

So, I'll keep what I queued when I received v1 for now.
Sorry for missing the edit to the message. You are correct that v2
just added one commit.

I like your rewording, if you feel like editing it.
I'm kinda neutral ;-).
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help