Thread (34 messages) 34 messages, 6 authors, 2019-05-02

Re: [PATCH v3 1/1] git clone <url> C:\cygwin\home\USER\repo' is working (again)

From: Johannes Schindelin <hidden>
Date: 2018-12-11 13:28:47

Hi Torsten,

On Tue, 11 Dec 2018, Torsten Bögershausen wrote:
On Mon, Dec 10, 2018 at 09:32:03AM +0100, Johannes Schindelin wrote:
quoted
On Sat, 8 Dec 2018, tboegi@web.de wrote:
quoted
And, before any cleanup is done, I sould like to ask if anybody
can build the code with VS and confirm that it works, please ?
Can you give me an easy-to-fetch branch?

Thanks,
Dscho
@Dscho: The branch should be here:
  https://github.com/tboegi/git/tree/tb.181208_0844_cygwin-dos-drive
  (or fetch it from Junio, please see below:)
I fetched it from you, as Junio frequently applies patches anywhere except
where they were developed. I'd rather see what you see. For the record,
this is the commit I tested: cc1e08eeb83b.

It builds fine here, and some cursory tests reveal that it works as
advertised (I ran t0001, t0060 and t5580).

However.

Can you please replace the rather unnecessary, very, very long
`win_path_utils_` function name prefix by the much better prefix `win32_`,
to keep in line with the current, already existing, surrounding files'
convention? Thanks a bunch.

Ciao,
Dscho
@Junio:
  Please keep tb/use-common-win32-pathfuncs-on-cygwin
  in pu for a while. I need to send a V4 to fix t5601 for cygwin.
 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help