Re: [PATCH v1 1/2] log -G: Ignore binary files

Junio C Hamano [off-list ref] hat am 27. November 2018 um 01:51 geschrieben:


Stefan Beller [off-list ref] writes:

quoted

On Wed, Nov 21, 2018 at 1:08 PM Thomas Braun
[off-list ref] wrote:

quoted

The -G <regex> option of log looks for the differences whose patch text
contains added/removed lines that match regex.

The concept of differences only makes sense for text files, therefore
we need to ignore binary files when searching with -G <regex> as well.

What about partial text/partial binary files?

Good point. You'd use "-a" (or "--text") to tell the diff machinery
to treat the contents as text, and the new logic must pay attention
to that command line option.

Yes exactly. Either use -a for the occasional use or a textconv filter
for permanent use.

Coming from the opposite side: I usually mark svg files as binary as the
textual diff is well, let's say uninspiring.