Re: [PATCH] files-backend.c: fix build error on Solaris

Carlo Arenas [off-list ref] writes:

Signed-off-by: Carlo Marcelo Arenas Belón <redacted>

Do you mean Tested-by: (meaning, you actually saw the breakage with
SunCC without the patch and also saw the patch fixed the breakage)?

clang with -Wpedantic also catch this (at least with Apple LLVM
version 10.0.0); recent versions of gcc also include that flag and at
least 8.2.0 shows a warning for it, so it might be worth adding it to
developer mode (maybe under the pedantic DEVOPTS).

Nice to know.

..., would this be something I should be adding?, what are the expectations around
warnings and compilers?

It may be a worthwhile thing to discuss, and as a discussion
starter, a patch would help ;-).