Re: [PATCH v1 2/2] log -S: Add test which searches in binary files
From: Junio C Hamano <hidden>
Date: 2018-11-22 01:34:12
Thomas Braun [off-list ref] writes:
The -S <regex> option of log looks for differences that changes the number of occurrences of the specified string (i.e. addition/deletion) in a file.
s/-S <regex>/-S<block of text>/ and s/the specified string/the specified block of text/ would make it more in line with how Documentation/gitdiffcore.txt explains it. The original discussion from early 2017 also explains with a pointer why the primary mode of -S is not <regex> but is <block of text>.
quoted hunk
diff --git a/t/t4209-log-pickaxe.sh b/t/t4209-log-pickaxe.sh index 42cc8afd8b..d430f6f2f9 100755 --- a/t/t4209-log-pickaxe.sh +++ b/t/t4209-log-pickaxe.sh@@ -128,4 +128,15 @@ test_expect_success 'log -G looks into binary files with textconv filter' ' test_cmp actual expected ' +test_expect_success 'log -S looks into binary files' ' + rm -rf .git && + git init &&
Same comment as the one for 1/2 applies here.
+ printf "a\0b" >data.bin && + git add data.bin && + git commit -m "message" && + git log -S a >actual && + git log >expected && + test_cmp actual expected +' + test_done
Other than these, I think both patches look sensible. Thanks for resurrecting the old topic and reigniting it.