Re: [PATCH-2] Change writing style
From: Junio C Hamano <hidden>
Date: 2018-11-17 09:04:17
Jacques Bodin-Hullin [off-list ref] writes:
Subject: Re: [PATCH-2] Change writing style
Let's do the usual "<area>: summary" instead. Perhaps
Subject: parse-options: lose an unnecessary space in an error message
It is obvious why it is done, so I do not see a need for any other
description in the body of the message for this change.
We still need the patch signed-off. cf. Documentation/SubmittingPatches
--- parse-options.c | 4 ++-- t/t0040-parse-options.sh | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
All changes look good to me.
quoted hunk
diff --git a/parse-options.c b/parse-options.c index 3b874a83a0c89..f5ef24155950b 100644 --- a/parse-options.c +++ b/parse-options.c@@ -352,7 +352,7 @@ static void check_typos(const char *arg, const struct option *options) return; if (starts_with(arg, "no-")) { - error ("did you mean `--%s` (with two dashes ?)", arg); + error("did you mean `--%s` (with two dashes)?", arg); exit(129); }@@ -360,7 +360,7 @@ static void check_typos(const char *arg, const struct option *options) if (!options->long_name) continue; if (starts_with(options->long_name, arg)) { - error ("did you mean `--%s` (with two dashes ?)", arg); + error("did you mean `--%s` (with two dashes)?", arg); exit(129); } }diff --git a/t/t0040-parse-options.sh b/t/t0040-parse-options.sh index 5b0560fa20e34..c442f9ae15ff8 100755 --- a/t/t0040-parse-options.sh +++ b/t/t0040-parse-options.sh@@ -222,7 +222,7 @@ test_expect_success 'non ambiguous option (after two options it abbreviates)' ' ' cat >typo.err <<\EOF -error: did you mean `--boolean` (with two dashes ?) +error: did you mean `--boolean` (with two dashes)? EOF test_expect_success 'detect possible typos' '@@ -232,7 +232,7 @@ test_expect_success 'detect possible typos' ' ' cat >typo.err <<\EOF -error: did you mean `--ambiguous` (with two dashes ?) +error: did you mean `--ambiguous` (with two dashes)? EOF test_expect_success 'detect possible typos' ' --https://github.com/git/git/pull/540