Thread (1 message) 1 message, 1 author, 2018-11-08

Re: [PATCH v5 10/10] merge-recursive: combine error handling

From: Junio C Hamano <hidden>
Date: 2018-11-08 05:25:30

Elijah Newren [off-list ref] writes:
From: Derrick Stolee <redacted>

In handle_rename_rename_1to2(), we have duplicated error handling
around colliding paths. Specifically, when we want to write out
the file and there is a directory or untracked file in the way,
we need to create a temporary file to hold the contents. This has
some special output to alert the user, and this output is
duplicated for each side of the conflict.

Simplify the call by generating this new path in a helper
function.

Signed-off-by: Derrick Stolee <redacted>
Signed-off-by: Elijah Newren <redacted>
---
 merge-recursive.c | 53 ++++++++++++++++++++++++-----------------------
 1 file changed, 27 insertions(+), 26 deletions(-)
Thanks, both.

Let's advance these patches to 'next' soonish.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help