On 10/19/2018 3:31 PM, Elijah Newren wrote:

+test_expect_success "setup nested conflicts" '

nit: should these test names be single-quoted? I see you using double-quotes
in PATCH 1/8 as well, but that seems to be because there are variables in
the test names.


...

+test_expect_failure "check nested conflicts" '

Same here.

+test_expect_success "setup nested conflicts from rename/rename(2to1)" '

+test_expect_failure "check nested conflicts from rename/rename(2to1)" '

Thanks,
-Stolee