Re: [PATCH v4 2/2] worktree: add per-worktree config files

Duy Nguyen [off-list ref] writes:

quoted

quoted

+extensions.worktreeConfig::
+     If set, by default "git config" reads from both "config" and
+     "config.worktree" file from GIT_DIR in that order. In
+     multiple working directory mode, "config" file is shared while
+     "config.worktree" is per-working directory (i.e., it's in
+     GIT_COMMON_DIR/worktrees/<id>/config.worktree)
+

This obviously conflicts with your 59-patch series, but more
importantly

 - I notice that this is the only description of extensions.* key in
   the configuration files.  Don't we have any other extension
   defined, and if so shouldn't we be describing them already (not
   as a part of this series, obviously)?

Right. We have two extensions already but it's described in
technical/repository-format.txt. I'll move this extension there
because it's written "This document will serve as the master list for
extensions." in that document.

quoted

 - If we are going to describe other extensions.* keys, do we want
   extensions-config.txt file to split this (and others) out and
   later rename it to config/extensions.txt?  Or do we want to
   collect related things together by logically not by name and have
   this extension described in config/worktree.txt instead, perhaps
   separate from other extensions.* keys?

I think we would go with config/extensions.txt because if grouping
logically, I'm not sure where extensions.preciousObjects and
extensions.partialClone would go.

OK, that sounds sensible.

Other than that, I am getting the feeling that everybody agrees that
the problem this topic addresses is worth addressing, and the design
and the implementation of the solution presented here is sensible.

If so, let's move it forward to 'next' and plan to merge it down to
'master'.  The "extensions.*" description can happen incrementally,.
I'd think.