Re: [PATCH v2 2/3] reset: add new reset.quiet config setting

Ben Peart [off-list ref] writes:

On 10/19/2018 1:11 PM, Jeff King wrote:

quoted

On Fri, Oct 19, 2018 at 01:10:34PM -0400, Eric Sunshine wrote:

quoted

On Fri, Oct 19, 2018 at 12:46 PM Jeff King [off-list ref] wrote:

quoted

On Fri, Oct 19, 2018 at 12:36:44PM -0400, Eric Sunshine wrote:

quoted

How does the user reverse this for a particular git-reset invocation?
There is no --no-quiet or --verbose option.

Perhaps you want to use OPT__VERBOSITY() instead of OPT__QUIET() in
builtin/reset.c and document that --verbose overrides --quiet and
reset.quiet (or something like that).

I think OPT__QUIET() provides --no-quiet, since it's really an
OPT_COUNTUP() under the hood. Saying "--no-quiet" should reset it back
to 0.

Okay. In any case, --no-quiet probably ought to be mentioned alongside
the "reset.quiet" option (and perhaps in git-reset.txt to as a way to
reverse "reset.quiet").

Yes, I'd agree with that.

-Peff

Makes sense.  I'll update the docs to say:

-q::
--quiet::
--no-quiet::
	Be quiet, only report errors.
+
With --no-quiet report errors and unstaged changes after reset.

Sounds good.  Thanks all.