Thread (1 message) 1 message, 1 author, 2018-10-19

Re: [PATCH] multi-pack-index: avoid dead store for struct progress

From: Junio C Hamano <hidden>
Date: 2018-10-19 02:26:29

Carlo Marcelo Arenas Belón  [off-list ref] writes:
quoted hunk
it is initialized unconditionally by a call to start_progress
below.

Signed-off-by: Carlo Marcelo Arenas Belón <redacted>
---
 midx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/midx.c b/midx.c
index ea2f3ffe2e..4fac0cd08a 100644
--- a/midx.c
+++ b/midx.c
@@ -941,7 +941,7 @@ static void midx_report(const char *fmt, ...)
 int verify_midx_file(const char *object_dir)
 {
 	uint32_t i;
-	struct progress *progress = NULL;
+	struct progress *progress;
 	struct multi_pack_index *m = load_multi_pack_index(object_dir, 1);
 	verify_midx_error = 0;
Both changes make sense.  It's kind of surprising that this still
matters, though; I would have expected a compiler would notice.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help