Thread (1 message) 1 message, 1 author, 2018-10-18

Re: [PATCH 5/9] submodule.c: do not copy around submodule list

From: Junio C Hamano <hidden>
Date: 2018-10-18 02:35:13

Jonathan Tan [off-list ref] writes:
quoted
By doing so we'll have access to the util pointer for longer that
contains the commits that we need to fetch, which will be
useful in a later patch.
It seems that the main point of this patch is so that the OIDs be stored
in changed_submodule_names, because you need them in a later patch. If
so, I would have expected a commit title like "submodule: store OIDs in
changed_submodule_names".

...
This patch looks good, except that the commit title and message could
perhaps be clearer.
Thanks for a thoughtful review; not just this step, but for your review
comments on all the other steps in the series are very helpful.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help