Thread (3 messages) flat view 3 messages, 3 authors, 2018-10-17

Re: [PATCH 1/1] subtree: make install targets depend on build targets

From: Jonathan Nieder <hidden>
Date: 2018-10-17 02:45:09

Possibly related (same subject, not in this thread)

Hi,

Christian Hesse wrote:
quoted hunk ↗ jump to hunk
--- a/contrib/subtree/Makefile
+++ b/contrib/subtree/Makefile
@@ -69,11 +69,11 @@ install: $(GIT_SUBTREE)
[...]
-install-html: $(GIT_SUBTREE_HTML)
+install-html: html
This broke the build for me:

 make[2]: Entering directory '/build/git-2.19.1+next.20181016/contrib/subtree'
 install -m 644 html /build/git-2.19.1+next.20181016/debian/tmp/usr/share/doc/git/html
 install: cannot stat 'html': No such file or directory
 make[2]: *** [Makefile:78: install-html] Error 1

The rule says

 install-html: html
	$(INSTALL) -d -m 755 $(DESTDIR)$(htmldir)
	$(INSTALL) -m 644 $^ $(DESTDIR)$(htmldir)

and $^ substitutes to "html" after this change.  How was this patch
tested?

Thanks,
Jonathan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help