Re: What's cooking in git.git (Oct 2018, #02; Sat, 13)

On Fri, Oct 12, 2018 at 12:44 PM Stefan Beller [off-list ref] wrote:

quoted

* sb/submodule-recursive-fetch-gets-the-tip (2018-10-11) 9 commits
 . builtin/fetch: check for submodule updates for non branch fetches
 . fetch: retry fetching submodules if needed objects were not fetched
 . submodule: fetch in submodules git directory instead of in worktree
 . repository: repo_submodule_init to take a submodule struct
 . submodule.c: do not copy around submodule list
 . submodule.c: move global changed_submodule_names into fetch submodule struct
 . submodule.c: sort changed_submodule_names before searching it
 . submodule.c: fix indentation
 . sha1-array: provide oid_array_filter

 "git fetch --recurse-submodules" may not fetch the necessary commit
 that is bound to the superproject, which is getting corrected.

 Ejected for now, as it has fallouts in places like t/helper/.

This is the first time I hear about that, I'll look into that.

I looked into that, and merging with origin/next only
had one merge conflict in submodule.c, easy to resolve.
It builds and tests cleanly after that.

What fallouts did you observe?

The tipmost commit there is also shoddy, I'll redo that.

I confused this series with sb/submodule-update-in-C
which got merged already, I may send a fixup commit there.

So it seems to me that this series is still good.

Thanks,
Stefan